Issue 34133002: Cover an example of equality and hashCode for each type of mirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34133002: Cover an example of equality and hashCode for each type of mirror. (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
ahe, gbracha

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cover an example of equality and hashCode for each type of mirror. BUG=http://dartbug.com/6680 R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=29015

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -4 lines)			Patch
	M	runtime/lib/mirrors_impl.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	tests/lib/mirrors/equality_test.dart	View		2 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/34133002/diff/1/tests/lib/mirrors/equality_test.dart File tests/lib/mirrors/equality_test.dart (right): https://codereview.chromium.org/34133002/diff/1/tests/lib/mirrors/equality_test.dart#newcode131 tests/lib/mirrors/equality_test.dart:131: : reflect(new BadEqualityHash()).type.methods[#==].parameters[0]}, /// 02: ok Long lines.

7 years, 2 months ago (2013-10-22 12:42:00 UTC) #3

rmacnak

7 years, 2 months ago (2013-10-22 18:16:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29015 (presubmit successful).

Expand Messages | Collapse Messages

Issue 34133002: Cover an example of equality and hashCode for each type of mirror. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages