Issue 341273007: Allow multiple dirs per package in the data returned by "pub list".

Issue 341273007: Allow multiple dirs per package in the data returned by "pub list". (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow multiple dirs per package in the data returned by "pub list". R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37565

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -31 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/package_map_provider.dart	View	4 chunks	+20 lines, -9 lines	2 comments	Download
M	pkg/analysis_server/lib/src/package_uri_resolver.dart	View	3 chunks	+13 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/package_map_provider_test.dart	View	1 chunk	+22 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/package_uri_resolver_test.dart	View	3 chunks	+32 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/341273007/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart File pkg/analysis_server/lib/src/package_map_provider.dart (right): https://codereview.chromium.org/341273007/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart#newcode96 pkg/analysis_server/lib/src/package_map_provider.dart:96: if (folders.isNotEmpty) { Move this out of the ...

6 years, 6 months ago (2014-06-20 20:06:59 UTC) #2

Paul Berry

https://codereview.chromium.org/341273007/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart File pkg/analysis_server/lib/src/package_map_provider.dart (right): https://codereview.chromium.org/341273007/diff/1/pkg/analysis_server/lib/src/package_map_provider.dart#newcode96 pkg/analysis_server/lib/src/package_map_provider.dart:96: if (folders.isNotEmpty) { On 2014/06/20 20:06:59, scheglov wrote: > ...

6 years, 6 months ago (2014-06-20 20:12:33 UTC) #3

Paul Berry

6 years, 6 months ago (2014-06-20 20:12:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37565 (presubmit successful).

Expand Messages | Collapse Messages