Rerun "pub list" when pubspec.lock changes.

Rerun "pub list" when pubspec.lock changes.

(Note: we don't actually hardcode the dependency on pubspec.lock--we
use the "input_files" field of the output from "pub list" which tells
us the dependency).

This required some refactoring: ContextDirectory has been eliminated
and its responsibilities (creating the analysis context, UriResolvers,
and SourceFactory) have been shifted to ContextDirectoryManager and
AnalysisServerContextDirectoryManager.  Accordingly,
AnalysisServer.folderMap now maps directly from folder to
AnalysisContext.

Note: we don't yet properly handle the case where one of the
dependencies output by "pub list" is outside of the context folder.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37826

[Brian Wilkerson, 2014-06-30 16:53:16]

LGTM

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:85: SourceFactory
_createSourceFactory(Map<String, List<Folder>> packageMap) {
Do we need to handle the case where the package map is either null or empty (for
non-pub contexts)?

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:88: new
ResourceUriResolver(resourceProvider),
I assume ResourceUriResolver handles file: URI's, in which case it probably
wants to be last in the list.

[Paul Berry, 2014-06-30 17:43:00]

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:85: SourceFactory
_createSourceFactory(Map<String, List<Folder>> packageMap) {
On 2014/06/30 16:53:16, Brian Wilkerson wrote:
> Do we need to handle the case where the package map is either null or empty
(for
> non-pub contexts)?

We don't need special code to handle an empty package map--PackageMapUriResolver
handles that fine.

You're right that non-pub contexts aren't handled correctly, but fixing that is
going to be more complex than handling null here--I'll also need to handle null
being returned from computePackageMap() in
ContextDirectoryManager._createContext() and
ContextDirectoryManager._handleWatchEvent().  I'll add TODO's and address that
in a future CL.

https://codereview.chromium.org/341123007/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:88: new
ResourceUriResolver(resourceProvider),
On 2014/06/30 16:53:16, Brian Wilkerson wrote:
> I assume ResourceUriResolver handles file: URI's, in which case it probably
> wants to be last in the list.

You're correct that ResourceUriResolver only handles "file:" URIs, but I think
this means that the order doesn't matter.  DartUriResolver handles only "dart:"
URIs, and PackageMapUriResolver handles only "package:" URIs, so the only
consequence of changing the order would be a negligible performance difference.

[Paul Berry, 2014-06-30 17:44:45]

Committed patchset #1 manually as r37826 (presubmit successful).