Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 340843003: Remove timers from Service_Isolate test (Closed)

Created:
6 years, 6 months ago by Cutch
Modified:
6 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove timers from Service_Isolate test because the internal C++ json parser can't handle floating point numbers. Committed: https://code.google.com/p/dart/source/detail?r=37462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M runtime/vm/service_test.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
TBR
6 years, 6 months ago (2014-06-18 20:16:47 UTC) #1
Cutch
Committed patchset #1 manually as r37462 (presubmit successful).
6 years, 6 months ago (2014-06-18 20:16:57 UTC) #2
srdjan
6 years, 6 months ago (2014-06-18 20:17:13 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698