Add support for adding/removing pubspec.yaml files.

Add support for adding/removing pubspec.yaml files.

Since this probably won't happen very often, we don't go to a great
deal of effort to handle it efficiently--we just destroy the old
context and create a new one.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37496

[Brian Wilkerson, 2014-06-18 18:19:39]

LGTM

[scheglov, 2014-06-18 18:32:05]

lgtm

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_directory_manager.dart (right):

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:34: File pubspecFile
= null;
Do we need "= null"?

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:51: static String
PUBSPEC_NAME = 'pubspec.yaml';
static const?

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:98: // remove old
contexts
"destroy old contexts" ?

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:102: // add new
contexts
"create new contexts"?

[Paul Berry, 2014-06-19 14:55:15]

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_directory_manager.dart (right):

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:34: File pubspecFile
= null;
On 2014/06/18 18:32:04, scheglov wrote:
> Do we need "= null"?

Technically, it's redundant, since uninitialized variables always have null as
their initial value.  However, since there is a code path that relies on this
initial value, I thought it would be nice to be explicit.

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:51: static String
PUBSPEC_NAME = 'pubspec.yaml';
On 2014/06/18 18:32:04, scheglov wrote:
> static const?

Done.

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:98: // remove old
contexts
On 2014/06/18 18:32:04, scheglov wrote:
> "destroy old contexts" ?

Done.

https://codereview.chromium.org/340773005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_directory_manager.dart:102: // add new
contexts
On 2014/06/18 18:32:04, scheglov wrote:
> "create new contexts"?

Done.

[Paul Berry, 2014-06-19 14:55:32]

Committed patchset #1 manually as r37496 (presubmit successful).