eventController interop with polymer.js

eventController interop with polymer.js

BUG=
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37435

[Jennifer Messerly, 2014-06-18 01:46:29]

This fixes the core-overlay interop issue I was seeing

[Siggi Cherem (dart-lang), 2014-06-18 01:51:42]

lgtm

https://codereview.chromium.org/340693002/diff/1/pkg/polymer/lib/src/instance...
File pkg/polymer/lib/src/instance.dart (right):

https://codereview.chromium.org/340693002/diff/1/pkg/polymer/lib/src/instance...
pkg/polymer/lib/src/instance.dart:194: set eventController(value) {
_jsElem['eventController'] = value; }
woah!

Should we add the type annotation here? Mainly I'm wondering about what the old
comment used to say.

[Jennifer Messerly, 2014-06-18 02:18:47]

https://codereview.chromium.org/340693002/diff/1/pkg/polymer/lib/src/instance...
File pkg/polymer/lib/src/instance.dart (right):

https://codereview.chromium.org/340693002/diff/1/pkg/polymer/lib/src/instance...
pkg/polymer/lib/src/instance.dart:194: set eventController(value) {
_jsElem['eventController'] = value; }
On 2014/06/18 01:51:42, Siggi Cherem (dart-lang) wrote:
> woah!
> 
> Should we add the type annotation here? Mainly I'm wondering about what the
old
> comment used to say.

Hmmm. We could put back Element, which is what PolymerEventBindings will
type-assert. But I removed it to address that TODO :). Ultimately any kind of
model should be allowed, not just a custom element, although that limitation is
convenient at the moment since it means it's serializable to JS.

Generally though, I'm finding dynamic works better with interop-y code. Might as
well take advantage of optional types where they make sense.

[Jennifer Messerly, 2014-06-18 02:33:21]

Committed patchset #1 manually as r37435 (presubmit successful).