Issue 340673002: VM service: List all instances of a class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340673002: VM service: List all instances of a class. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM service: List all instances of a class. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37465

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
	M	runtime/vm/service.cc	View		3 chunks	+62 lines, -2 lines	0 comments	Download
	M	runtime/vm/service_test.cc	View		1 chunk	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with small test suggestion https://codereview.chromium.org/340673002/diff/1/runtime/vm/service_test.cc File runtime/vm/service_test.cc (right): https://codereview.chromium.org/340673002/diff/1/runtime/vm/service_test.cc#newcode851 runtime/vm/service_test.cc:851: EXPECT_EQ(2, list.Length()); Might be ...

6 years, 6 months ago (2014-06-18 17:23:07 UTC) #2

koda

Committed patchset #1 manually as r37465 (presubmit successful).

6 years, 6 months ago (2014-06-18 20:55:12 UTC) #3

koda

6 years, 6 months ago (2014-06-18 20:55:32 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/340673002/diff/1/runtime/vm/service_test.cc
File runtime/vm/service_test.cc (right):

https://codereview.chromium.org/340673002/diff/1/runtime/vm/service_test.cc#n...
runtime/vm/service_test.cc:851: EXPECT_EQ(2, list.Length());
On 2014/06/18 17:23:07, Cutch wrote:
> Might be good idea to have a test which verifies that limit does truncate the
> list (i.e. live instances > limit).

Done.

Expand Messages | Collapse Messages