Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 34053007: Mark mirror_printer_test as failing on browsers. (Closed)

Created:
7 years, 2 months ago by zarah
Modified:
7 years, 2 months ago
Reviewers:
ricow1, Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark mirror_printer_test as failing on browsers. Committed: https://code.google.com/p/dart/source/detail?r=28996

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
zarah
Committed patchset #1 manually as r28996 (presubmit successful).
7 years, 2 months ago (2013-10-22 12:04:25 UTC) #1
zarah
7 years, 2 months ago (2013-10-22 12:27:00 UTC) #2
Johnni Winther
lgtm
7 years, 2 months ago (2013-10-22 12:41:52 UTC) #3
ricow1
DBC https://codereview.chromium.org/34053007/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status File tests/compiler/dart2js_extra/dart2js_extra.status (right): https://codereview.chromium.org/34053007/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status#newcode46 tests/compiler/dart2js_extra/dart2js_extra.status:46: [ $compiler == dart2js && ( $runtime == ...
7 years, 2 months ago (2013-10-22 13:12:48 UTC) #4
zarah
7 years, 2 months ago (2013-10-22 13:45:15 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/34053007/diff/1/tests/compiler/dart2js_extra/...
File tests/compiler/dart2js_extra/dart2js_extra.status (right):

https://codereview.chromium.org/34053007/diff/1/tests/compiler/dart2js_extra/...
tests/compiler/dart2js_extra/dart2js_extra.status:46: [ $compiler == dart2js &&
( $runtime == ff || $runtime == safari || $runtime == ie9 || $runtime == chrome)
]
On 2013/10/22 13:12:48, ricow1 wrote:
> if this actually fails on all browsers you can just use:
> [ $compiler == dart2js && $browser ]
> This would then also include drt where we are also failing and IE10, where we
> are currently not running dart2js extra tests, but I assume it would fail if
we
> did?
Done, thanks.

Powered by Google App Engine
This is Rietveld 408576698