Issue 340493002: Clear future callbacks when the future is completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340493002: Clear future callbacks when the future is completed. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 6 months ago

Reviewers:
Søren Gjesse, floitsch

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clear future callbacks when the future is completed. BUG= http://dartbug.com/19492 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37386

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	sdk/lib/async/future_impl.dart	View		2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r37386 (presubmit successful).

6 years, 6 months ago (2014-06-17 08:13:24 UTC) #3

floitsch

6 years, 6 months ago (2014-06-17 08:56:35 UTC) #4

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/340493002/diff/1/sdk/lib/async/future_impl.dart
File sdk/lib/async/future_impl.dart (right):

https://codereview.chromium.org/340493002/diff/1/sdk/lib/async/future_impl.da...
sdk/lib/async/future_impl.dart:144: _onValueCallback = null, _errorTestCallback
= null,
There are lots of null-initializations that can be dropped now.

Expand Messages | Collapse Messages