Issue 340343006: Send console messages through interaction manager.

Issue 340343006: Send console messages through interaction manager. (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Send console messages through interaction manager. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37602

Patch Set 1 : Merged with r37600. #

Patch Set 2 : Mark comment as proper TODO. #

Total comments: 2

Patch Set 3 : Add comments. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -43 lines)			Patch
M	dart/site/try/src/compilation.dart	View	1	10 chunks	+6 lines, -35 lines	0 comments	Download
M	dart/site/try/src/interaction_manager.dart	View	1 2	10 chunks	+110 lines, -7 lines	0 comments	Download
M	dart/site/try/src/ui.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/340343006/diff/80001/dart/site/try/src/interaction_manager.dart File dart/site/try/src/interaction_manager.dart (right): https://codereview.chromium.org/340343006/diff/80001/dart/site/try/src/interaction_manager.dart#newcode83 dart/site/try/src/interaction_manager.dart:83: const Duration HEARTBEAT_INTERVAL = const Duration(milliseconds: 50); Add ...

6 years, 6 months ago (2014-06-23 14:50:01 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/340343006/diff/80001/dart/site/try/src/interaction_manager.dart File dart/site/try/src/interaction_manager.dart (right): https://codereview.chromium.org/340343006/diff/80001/dart/site/try/src/interaction_manager.dart#newcode83 dart/site/try/src/interaction_manager.dart:83: const Duration HEARTBEAT_INTERVAL = const Duration(milliseconds: ...

6 years, 6 months ago (2014-06-23 15:15:55 UTC) #3

ahe

Committed patchset #3 manually as r37602 (presubmit successful).

6 years, 6 months ago (2014-06-23 15:19:59 UTC) #4

ahe

6 years, 6 months ago (2014-06-23 15:22:17 UTC) #5

Message was sent while issue was closed.

FYI, filed https://code.google.com/p/dart/issues/detail?id=19614 to track
developing automated tests of this.

Expand Messages | Collapse Messages