'Element' and 'Outline' implementations for the new server API.

'Element' and 'Outline' implementations for the new server API.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=37463

[Brian Wilkerson, 2014-06-18 20:37:10]

LGTM

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:10: import
'package:analyzer/src/generated/element.dart' as ane;
What does "ane" stand for? Given that I can't tell, perhaps something like
"engine" or "element" might be better.

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:41: '';
Unfortunate line break...

[scheglov, 2014-06-18 20:43:27]

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:10: import
'package:analyzer/src/generated/element.dart' as ane;
On 2014/06/18 20:37:09, Brian Wilkerson wrote:
> What does "ane" stand for? Given that I can't tell, perhaps something like
> "engine" or "element" might be better.

Done.

https://codereview.chromium.org/340183003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:41: '';
On 2014/06/18 20:37:09, Brian Wilkerson wrote:
> Unfortunate line break...

Yes.
At some point we need to improve the formatter.

[scheglov, 2014-06-18 20:44:29]

Committed patchset #1 manually as r37463 (presubmit successful).

[Paul Berry, 2014-06-18 21:21:51]

lgtm