Issue 340113002: Fix our initial dead phi elimination in the presence of try-catch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340113002: Fix our initial dead phi elimination in the presence of try-catch. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix our initial dead phi elimination in the presence of try-catch. BUG=dartbug.com/19519 TEST=tests/language/try_catch_optimized4_test.dart R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37444

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed feedback #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -1 line)			Patch
	M	runtime/vm/flow_graph.cc	View	1	2 chunks	+30 lines, -1 line	0 comments	Download
	A	tests/language/try_catch_optimized4_test.dart	View		1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/340113002/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/340113002/diff/1/runtime/vm/flow_graph.cc#newcode1011 runtime/vm/flow_graph.cc:1011: if (phi == NULL || phi->env_use_list() == NULL) ...

6 years, 6 months ago (2014-06-18 14:21:27 UTC) #2

Florian Schneider

https://codereview.chromium.org/340113002/diff/1/runtime/vm/flow_graph.cc File runtime/vm/flow_graph.cc (right): https://codereview.chromium.org/340113002/diff/1/runtime/vm/flow_graph.cc#newcode1011 runtime/vm/flow_graph.cc:1011: if (phi == NULL || phi->env_use_list() == NULL) continue; ...

6 years, 6 months ago (2014-06-18 14:25:41 UTC) #3

Florian Schneider

6 years, 6 months ago (2014-06-18 14:27:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37444 (presubmit successful).

Expand Messages | Collapse Messages