Fix for subscribing for notifications after analysis.

Fix for subscribing for notifications after analysis.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=37455

[Brian Wilkerson, 2014-06-18 16:25:11]

LGTM

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:403: CompilationUnit dartUnit =
resolveCompilationUnit(file);
I think we need to only get the compilation unit if it has already been
resolved. Otherwise we're potentially doing a lot of analysis in response to a
request. And if it hasn't already been resolved then we'll send the
notifications after analysis is performed.

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:462: return
context.resolveCompilationUnit2(unitSource, librarySources[0]);
We need to handle the case where a file is in more than one library, both here
and when analysis has completed. (A TODO comment would be fine for now.)

[scheglov, 2014-06-18 17:38:27]

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:403: CompilationUnit dartUnit =
resolveCompilationUnit(file);
On 2014/06/18 16:25:11, Brian Wilkerson wrote:
> I think we need to only get the compilation unit if it has already been
> resolved. Otherwise we're potentially doing a lot of analysis in response to a
> request. And if it hasn't already been resolved then we'll send the
> notifications after analysis is performed.

Agree.
Done.

https://codereview.chromium.org/339933006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:462: return
context.resolveCompilationUnit2(unitSource, librarySources[0]);
On 2014/06/18 16:25:11, Brian Wilkerson wrote:
> We need to handle the case where a file is in more than one library, both here
> and when analysis has completed. (A TODO comment would be fine for now.)

AFAIK multiple libraries matter only for navigation.

[scheglov, 2014-06-18 17:38:39]

Committed patchset #2 manually as r37455 (presubmit successful).