Issue 33903003: Fixing polymer element registration when extending tag extensions

Issue 33903003: Fixing polymer element registration when extending tag extensions (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing polymer element registration when extending tag extensions BUG=14127 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29006

Patch Set 2 : Sync to ToT #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -10 lines)			Patch
M	pkg/pkg.status	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/src/declaration.dart	View		2 chunks	+9 lines, -4 lines	2 comments	Download
A	pkg/polymer/test/register_test.dart	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A +	pkg/polymer/test/register_test.html	View		1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #2 manually as r29006 (presubmit successful).

7 years, 2 months ago (2013-10-22 16:20:11 UTC) #3

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/33903003/diff/50001/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (right): https://codereview.chromium.org/33903003/diff/50001/pkg/polymer/lib/src/declaration.dart#newcode245 pkg/polymer/lib/src/declaration.dart:245: var nativeExtends = baseTag; nit: merge baseTag or ...

7 years, 2 months ago (2013-10-22 16:44:17 UTC) #4

Jennifer Messerly

7 years, 2 months ago (2013-10-22 21:41:47 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/33903003/diff/50001/pkg/polymer/lib/src/decla...
File pkg/polymer/lib/src/declaration.dart (right):

https://codereview.chromium.org/33903003/diff/50001/pkg/polymer/lib/src/decla...
pkg/polymer/lib/src/declaration.dart:237: void registerType(String name) {
retroactive question: why don't we pass in "extendee" from the caller?

Polymer uses that in the "register" function ... if the value is unreliable, it
will be a problem up there too. I suspect either this search-up-the-chain is
unnecessary, or if it is necessary, it should happen sooner...

Expand Messages | Collapse Messages