Issue 338893006: Use mirror-free LRU test for dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338893006: Use mirror-free LRU test for dart2js (Closed)

Created:
6 years, 6 months ago by herhut

Modified:
6 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use mirror-free LRU test for dart2js BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37589

Patch Set 2 : Share expectations between both versions #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -39 lines)			Patch
A +	tests/compiler/dart2js_native/lru_test.dart	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/lib/mirrors/lru_expect.dart	View	1	2 chunks	+4 lines, -11 lines	0 comments	Download
M	tests/lib/mirrors/lru_test.dart	View	1	2 chunks	+3 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/338893006/diff/1/tests/compiler/dart2js_native/lru_test.dart File tests/compiler/dart2js_native/lru_test.dart (right): https://codereview.chromium.org/338893006/diff/1/tests/compiler/dart2js_native/lru_test.dart#newcode8 tests/compiler/dart2js_native/lru_test.dart:8: main() { If you abstract the creation of ...

6 years, 6 months ago (2014-06-23 08:38:30 UTC) #2

herhut

6 years, 6 months ago (2014-06-23 09:42:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37589 (presubmit successful).

Expand Messages | Collapse Messages

Issue 338893006: Use mirror-free LRU test for dart2js (Closed)

Description

Patch Set 1 #

Patch Set 2 : Share expectations between both versions #

Messages