Issue 33833003: Updated tests for fillText to better account for off-by-one errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33833003: Updated tests for fillText to better account for off-by-one errors. (Closed)

Created:
7 years, 2 months ago by Andrei Mouravski

Modified:
7 years, 2 months ago

Reviewers:
Emily Fortuna, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updated tests for fillText to better account for off-by-one errors. Committed: https://code.google.com/p/dart/source/detail?r=28969

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -24 lines)			Patch
	M	tests/html/canvasrenderingcontext2d_test.dart	View		2 chunks	+29 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Committed patchset #1 manually as r28969 (presubmit successful).

7 years, 2 months ago (2013-10-21 23:18:20 UTC) #3

siva

I am trying to understand why this off-by-one error was found only on the build ...

7 years, 2 months ago (2013-10-21 23:21:16 UTC) #4

Andrei Mouravski

7 years, 2 months ago (2013-10-21 23:47:49 UTC) #5

Message was sent while issue was closed.

On 2013/10/21 23:21:16, siva wrote:
> I am trying to understand why this off-by-one error was found only on the
build
> bot and not in your local test run of dartium tests?

No idea. I probably used the wrong options somehow. :[

Expand Messages | Collapse Messages