Issue 33813003: Do not generate a compile-time error if there is more than one catch-all clause

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33813003: Do not generate a compile-time error if there is more than one catch-all clause (Closed)

Created:
7 years, 2 months ago by hausner

Modified:
7 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not generate a compile-time error if there is more than one catch-all clause This includes catch clauses with malformed types, which are essentially catch-all clauses. The spec does not mandate such a compile-time error. (It probably did a long time ago.) Fixes issue 8601, 12159, 13019 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28999

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -32 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	3 chunks	+0 lines, -4 lines	0 comments	Download
D	tests/language/throw7_test.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

7 years, 2 months ago (2013-10-22 15:44:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28999 (presubmit successful).

Expand Messages | Collapse Messages