Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337943002: Adjust server for API changes (Closed)

Created:
6 years, 6 months ago by Brian Wilkerson
Modified:
6 years, 6 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+613 lines, -94 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 3 chunks +57 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +10 lines, -23 lines 0 comments Download
A pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +49 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/domain_edit.dart View 1 chunk +134 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/domain_search.dart View 1 chunk +82 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 9 chunks +11 lines, -29 lines 0 comments Download
A pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/domain_edit_test.dart View 1 chunk +95 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/domain_search_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
6 years, 6 months ago (2014-06-15 17:57:46 UTC) #1
scheglov
LGTM https://codereview.chromium.org/337943002/diff/1/pkg/analysis_server/lib/src/constants.dart File pkg/analysis_server/lib/src/constants.dart (right): https://codereview.chromium.org/337943002/diff/1/pkg/analysis_server/lib/src/constants.dart#newcode10 pkg/analysis_server/lib/src/constants.dart:10: const String SERVER_GET_VERSION = 'server.getVersion'; Great! https://codereview.chromium.org/337943002/diff/1/pkg/analysis_server/lib/src/protocol.dart File ...
6 years, 6 months ago (2014-06-15 18:08:15 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/337943002/diff/1/pkg/analysis_server/lib/src/protocol.dart File pkg/analysis_server/lib/src/protocol.dart (right): https://codereview.chromium.org/337943002/diff/1/pkg/analysis_server/lib/src/protocol.dart#newcode300 pkg/analysis_server/lib/src/protocol.dart:300: result[i] = elementConverter(new RequestDatum(request, "$path.$i", list[i])); No, it didn't ...
6 years, 6 months ago (2014-06-16 15:05:16 UTC) #3
Brian Wilkerson
6 years, 6 months ago (2014-06-16 18:41:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r37368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698