Add a tearDown function to scheduled_test.

Add a tearDown function to scheduled_test.

R=rnystrom@google.com
BUG=15689
Committed: https://code.google.com/p/dart/source/detail?r=37835

[Bob Nystrom, 2014-06-27 17:04:54]

lgtm

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
File pkg/scheduled_test/lib/scheduled_test.dart (right):

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:40: /// This is set for each test
during `unittest.setUp`.
tearDown.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:125: _initializedForGroup =
wasInitializedForGroup;
Is it worth doing this in a finally block?

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:164: /// have begun.
Would be good to point the reader to docs for the way to do teardown after the
scheduled has completed (currentSchedule.onComplete?).

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
File pkg/scheduled_test/test/scheduled_test/tear_down_test.dart (right):

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:48:
expectTestsFail('synchronous errors in tearDown will cause tests to fail', () {
Long line (I'd just delete "will").

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:60:
expectTestsPass('synchronous errors in tearDown will cause onException to run',
And here.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:139: var
tearDownInnerRun = false;
Nit, but I'd find these easier to read as "outerTearDownRun" and
"innerTearDownRun".

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:141: tearDown(() {
Expect that innerTearDown is false here to validate the order that nested
teardowns are run.

[nweiz, 2014-06-30 21:10:21]

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
File pkg/scheduled_test/lib/scheduled_test.dart (right):

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:40: /// This is set for each test
during `unittest.setUp`.
On 2014/06/27 17:04:53, Bob Nystrom wrote:
> tearDown.

It actually is set during unittest's setUp.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:125: _initializedForGroup =
wasInitializedForGroup;
On 2014/06/27 17:04:53, Bob Nystrom wrote:
> Is it worth doing this in a finally block?

I really doubt anyone is going to be doing serious exception handling at the top
level of a test.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/lib/sched...
pkg/scheduled_test/lib/scheduled_test.dart:164: /// have begun.
On 2014/06/27 17:04:53, Bob Nystrom wrote:
> Would be good to point the reader to docs for the way to do teardown after the
> scheduled has completed (currentSchedule.onComplete?).

Done.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
File pkg/scheduled_test/test/scheduled_test/tear_down_test.dart (right):

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:48:
expectTestsFail('synchronous errors in tearDown will cause tests to fail', () {
On 2014/06/27 17:04:54, Bob Nystrom wrote:
> Long line (I'd just delete "will").

Done.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:60:
expectTestsPass('synchronous errors in tearDown will cause onException to run',
On 2014/06/27 17:04:54, Bob Nystrom wrote:
> And here.

Done.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:139: var
tearDownInnerRun = false;
On 2014/06/27 17:04:54, Bob Nystrom wrote:
> Nit, but I'd find these easier to read as "outerTearDownRun" and
> "innerTearDownRun".

Done.

https://codereview.chromium.org/337843008/diff/1/pkg/scheduled_test/test/sche...
pkg/scheduled_test/test/scheduled_test/tear_down_test.dart:141: tearDown(() {
On 2014/06/27 17:04:53, Bob Nystrom wrote:
> Expect that innerTearDown is false here to validate the order that nested
> teardowns are run.

Done.

[nweiz, 2014-06-30 21:11:15]

Committed patchset #2 manually as r37835 (presubmit successful).