Issue 337753003: Update dart2js test expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337753003: Update dart2js test expectations. (Closed)

Created:
6 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update dart2js test expectations. Committed: https://code.google.com/p/dart/source/detail?r=37357

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tests/co19/co19-dart2js.status	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	tests/compiler/dart2js/dart2js.status	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r37357 (presubmit successful).

6 years, 6 months ago (2014-06-16 11:35:44 UTC) #2

floitsch

6 years, 6 months ago (2014-06-16 12:49:42 UTC) #3

Message was sent while issue was closed.

LGTM with comment.

We need to agree on a solution on this problem asap.

https://codereview.chromium.org/337753003/diff/1/tests/compiler/dart2js/dart2...
File tests/compiler/dart2js/dart2js.status (right):

https://codereview.chromium.org/337753003/diff/1/tests/compiler/dart2js/dart2...
tests/compiler/dart2js/dart2js.status:26: space_test: Crash, Fail OK # URIs must
not contain spaces.
It's not ok to fail.

Expand Messages | Collapse Messages