Issue 337503003: Fix a bug in ParallelMoveResolver::AllocateScratchRegister, where we end up allocating PC on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337503003: Fix a bug in ParallelMoveResolver::AllocateScratchRegister, where we end up allocating PC on ARM. (Closed)

Created:
6 years, 6 months ago by ngeoffray

Modified:
6 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), fschneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a bug in ParallelMoveResolver::AllocateScratchRegister, where we end up allocating PC on ARM. 1) Iterate from first_free_register to last_free_register to ensure we're not using protected registers. 2) Break when finding an ok register. 2) fixes allocating PC on ARM by itself, but we could need 1) for another architecture. The reason this has not been exposed yet, is because we call this method for a memory <-> memory swap, which almost never happens on ARM. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37304

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -9 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	4 chunks	+13 lines, -8 lines	0 comments	Download
A	tests/language/memory_swap_test.dart	View	1 chunk	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

6 years, 6 months ago (2014-06-13 08:02:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37304 (presubmit successful).

Expand Messages | Collapse Messages