Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337383005: PackageMapUriResolver for Dart server. (Closed)

Created:
6 years, 6 months ago by scheglov
Modified:
6 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

PackageMapUriResolver for Dart server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37431

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -17 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java View 1 chunk +8 lines, -6 lines 2 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +42 lines, -7 lines 2 comments Download
A pkg/analysis_server/lib/src/package_uri_resolver.dart View 1 chunk +90 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +40 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/package_uri_resolver_test.dart View 1 chunk +139 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 6 months ago (2014-06-17 21:18:44 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/337383005/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java (right): https://codereview.chromium.org/337383005/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java#newcode51 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java:51: while (true) { Given that the while is ...
6 years, 6 months ago (2014-06-17 21:38:23 UTC) #2
scheglov
https://codereview.chromium.org/337383005/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java (right): https://codereview.chromium.org/337383005/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java#newcode51 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java:51: while (true) { On 2014/06/17 21:38:23, Brian Wilkerson wrote: ...
6 years, 6 months ago (2014-06-17 22:50:34 UTC) #3
scheglov
6 years, 6 months ago (2014-06-17 22:52:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r37431 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698