Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 336683003: Light-weight stats counters for experiments. (Closed)

Created:
6 years, 6 months ago by koda
Modified:
6 years, 6 months ago
Reviewers:
Cutch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Light-weight stats counters for temporary experiments/debugging. A single statement is enough to add a counter: ... Isolate::Current()->counters()->Increment("allocated", size_in_bytes); ... I've been using these myself for a while now, but figured others might find them useful too. They are not intended for production use, just temporary local experiments/investigation. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37367

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -6 lines) Patch
A runtime/vm/counters.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A runtime/vm/counters.cc View 1 1 chunk +40 lines, -0 lines 2 comments Download
M runtime/vm/isolate.h View 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/object_graph_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
6 years, 6 months ago (2014-06-13 00:02:16 UTC) #1
Cutch
lgtm and looks useful.
6 years, 6 months ago (2014-06-13 19:49:37 UTC) #2
Ivan Posva
DBC -ip https://codereview.chromium.org/336683003/diff/40001/runtime/vm/counters.cc File runtime/vm/counters.cc (right): https://codereview.chromium.org/336683003/diff/40001/runtime/vm/counters.cc#newcode8 runtime/vm/counters.cc:8: #include <map> Please add a TODO to ...
6 years, 6 months ago (2014-06-13 22:14:32 UTC) #3
koda
https://codereview.chromium.org/336683003/diff/40001/runtime/vm/counters.cc File runtime/vm/counters.cc (right): https://codereview.chromium.org/336683003/diff/40001/runtime/vm/counters.cc#newcode8 runtime/vm/counters.cc:8: #include <map> On 2014/06/13 22:14:32, Ivan Posva wrote: > ...
6 years, 6 months ago (2014-06-16 17:12:48 UTC) #4
koda
6 years, 6 months ago (2014-06-16 17:13:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r37367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698