Issue 33593003: Reapply remove upgradeCustomElement methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33593003: Reapply remove upgradeCustomElement methods. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply remove upgradeCustomElement methods. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28960

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -63 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+2 lines, -14 lines	1 comment	Download
M	tests/html/custom/created_callback_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/document_register_basic_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/entered_left_view_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/html/custom_elements_test.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/html/utils.dart	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_Platform.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	tools/dom/src/dartium_Platform.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Take two. Same CL, just changed the tests to pass. :-) https://codereview.chromium.org/33593003/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): ...

7 years, 2 months ago (2013-10-21 21:47:26 UTC) #1

Emily Fortuna

7 years, 2 months ago (2013-10-21 21:55:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28960 (presubmit successful).

Expand Messages | Collapse Messages