Handle null content in ContentChange.

Handle null content in ContentChange.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37328

[scheglov, 2014-06-13 16:55:54]

LGTM

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:405: bool get isNull => datum == null;
Should we add a documentation for it?

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_analysis_test.dart (right):

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_analysis_test.dart:355: * Send an updateContent
request for testFile.
Would be good to wrap constants with ``.

Send an `updateContent` request for [testFile].

[Brian Wilkerson, 2014-06-13 20:11:05]

LGTM

[Paul Berry, 2014-06-13 20:23:01]

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/protocol.dart (right):

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/protocol.dart:405: bool get isNull => datum == null;
On 2014/06/13 16:55:53, scheglov wrote:
> Should we add a documentation for it?

I couldn't think of a documentation comment that wasn't so obvious that it
looked silly, e.g.:

/**
 * True if the datum is null.
 */
bool get isNull => datum == null;

I'm open to suggestions.

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/test/dom...
File pkg/analysis_server/test/domain_analysis_test.dart (right):

https://codereview.chromium.org/335853003/diff/1/pkg/analysis_server/test/dom...
pkg/analysis_server/test/domain_analysis_test.dart:355: * Send an updateContent
request for testFile.
On 2014/06/13 16:55:54, scheglov wrote:
> Would be good to wrap constants with ``.
> 
> Send an `updateContent` request for [testFile].

Done.

[Paul Berry, 2014-06-13 20:23:28]

Committed patchset #1 manually as r37328 (presubmit successful).