Issue 335463003: Report error only for elements we intend to upgrade.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335463003: Report error only for elements we intend to upgrade. (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 6 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report error only for elements we intend to upgrade. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37249

Patch Set 1 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	pkg/web_components/lib/dart_support.js	View		3 chunks	+11 lines, -4 lines	2 comments	Download
	M	pkg/web_components/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/335463003/diff/20001/pkg/web_components/lib/dart_support.js File pkg/web_components/lib/dart_support.js (right): https://codereview.chromium.org/335463003/diff/20001/pkg/web_components/lib/dart_support.js#newcode109 pkg/web_components/lib/dart_support.js:109: if (!!upgraders[name]) reportError(name); I don't think !! is ...

6 years, 6 months ago (2014-06-12 00:51:05 UTC) #2

Siggi Cherem (dart-lang)

thx https://codereview.chromium.org/335463003/diff/20001/pkg/web_components/lib/dart_support.js File pkg/web_components/lib/dart_support.js (right): https://codereview.chromium.org/335463003/diff/20001/pkg/web_components/lib/dart_support.js#newcode109 pkg/web_components/lib/dart_support.js:109: if (!!upgraders[name]) reportError(name); On 2014/06/12 00:51:05, John Messerly ...

6 years, 6 months ago (2014-06-12 01:03:24 UTC) #3

Siggi Cherem (dart-lang)

6 years, 6 months ago (2014-06-12 01:03:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37249 (presubmit successful).

Expand Messages | Collapse Messages