Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335173002: Save ICData of unoptimized code in the function, thus preserving it across repated unoptimized comp… (Closed)

Created:
6 years, 6 months ago by srdjan
Modified:
6 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Save ICData of unoptimized code in the function, thus preserving it across repated unoptimized compilations. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37378

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -44 lines) Patch
M runtime/vm/compiler.cc View 1 2 3 4 5 6 4 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 2 3 4 5 6 2 chunks +17 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 3 4 5 6 3 chunks +65 lines, -6 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 5 6 6 chunks +16 lines, -16 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 3 chunks +53 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 1 chunk +8 lines, -6 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 2 chunks +5 lines, -9 lines 0 comments Download
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
6 years, 6 months ago (2014-06-16 21:07:17 UTC) #1
Cutch
lgtm with suggested renames. https://codereview.chromium.org/335173002/diff/90001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/335173002/diff/90001/runtime/vm/compiler.cc#newcode244 runtime/vm/compiler.cc:244: static RawArray* ComputeICDataArray(const Function& function) ...
6 years, 6 months ago (2014-06-16 21:39:42 UTC) #2
srdjan
https://codereview.chromium.org/335173002/diff/90001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/335173002/diff/90001/runtime/vm/compiler.cc#newcode244 runtime/vm/compiler.cc:244: static RawArray* ComputeICDataArray(const Function& function) { On 2014/06/16 21:39:42, ...
6 years, 6 months ago (2014-06-16 21:58:09 UTC) #3
srdjan
6 years, 6 months ago (2014-06-16 22:24:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #7 manually as r37378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698