Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 334703004: pkg/http: updated unittest dependency, removed unused imports (Closed)

Created:
6 years, 6 months ago by kevmoo
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/http: updated unittest dependency, removed unused imports R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37289

Patch Set 1 #

Total comments: 7

Patch Set 2 : changelog tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M pkg/http/CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/http/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/http/test/html/streamed_request_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/http/test/html/utils.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/http/test/io/streamed_request_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/streamed_request_test.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
https://codereview.chromium.org/334703004/diff/1/pkg/http/test/html/streamed_request_test.dart File pkg/http/test/html/streamed_request_test.dart (right): https://codereview.chromium.org/334703004/diff/1/pkg/http/test/html/streamed_request_test.dart#newcode38 pkg/http/test/html/streamed_request_test.dart:38: } end with newline https://codereview.chromium.org/334703004/diff/1/pkg/http/test/io/streamed_request_test.dart File pkg/http/test/io/streamed_request_test.dart (right): https://codereview.chromium.org/334703004/diff/1/pkg/http/test/io/streamed_request_test.dart#newcode58 ...
6 years, 6 months ago (2014-06-12 20:25:34 UTC) #1
nweiz
lgtm https://codereview.chromium.org/334703004/diff/1/pkg/http/CHANGELOG.md File pkg/http/CHANGELOG.md (right): https://codereview.chromium.org/334703004/diff/1/pkg/http/CHANGELOG.md#newcode5 pkg/http/CHANGELOG.md:5: * Remove unused imports in tests. This isn't ...
6 years, 6 months ago (2014-06-12 20:41:18 UTC) #2
kevmoo
https://codereview.chromium.org/334703004/diff/1/pkg/http/CHANGELOG.md File pkg/http/CHANGELOG.md (right): https://codereview.chromium.org/334703004/diff/1/pkg/http/CHANGELOG.md#newcode5 pkg/http/CHANGELOG.md:5: * Remove unused imports in tests. On 2014/06/12 20:41:18, ...
6 years, 6 months ago (2014-06-12 20:56:47 UTC) #3
kevmoo
6 years, 6 months ago (2014-06-12 20:57:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698