Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 334543002: Use a mock SDK for most analysis server tests. (Closed)

Created:
6 years, 6 months ago by Paul Berry
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use a mock SDK for most analysis server tests. This should allow the tests to complete quickly on slower buildbots. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37281

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 2 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
6 years, 6 months ago (2014-06-11 22:51:44 UTC) #1
Brian Wilkerson
LGTM
6 years, 6 months ago (2014-06-11 23:01:29 UTC) #2
regis
On 2014/06/11 23:01:29, Brian Wilkerson wrote: > LGTM Please, as part of this cl, enable ...
6 years, 6 months ago (2014-06-11 23:03:10 UTC) #3
scheglov
LGTM
6 years, 6 months ago (2014-06-11 23:33:09 UTC) #4
Paul Berry
6 years, 6 months ago (2014-06-12 16:52:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r37281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698