Issue 334363004: Gracefully handle a missing locked version in pub get.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334363004: Gracefully handle a missing locked version in pub get. (Closed)

Created:
6 years, 6 months ago by nweiz

Modified:
6 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Gracefully handle a missing locked version in pub get. R=rnystrom@google.com BUG=19221 Committed: https://code.google.com/p/dart/source/detail?r=37424

Patch Set 2 : code review #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/get/hosted/unlock_if_version_doesnt_exist_test.dart	View	1	1 chunk	+10 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/test_pub.dart	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/334363004/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/334363004/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode224 sdk/lib/_internal/pub/test/test_pub.dart:224: void servePackages(List<Map> pubspecs, {bool overwrite: false}) { overwrite ...

6 years, 6 months ago (2014-06-17 20:09:26 UTC) #2

nweiz

https://codereview.chromium.org/334363004/diff/1/sdk/lib/_internal/pub/test/test_pub.dart File sdk/lib/_internal/pub/test/test_pub.dart (right): https://codereview.chromium.org/334363004/diff/1/sdk/lib/_internal/pub/test/test_pub.dart#newcode224 sdk/lib/_internal/pub/test/test_pub.dart:224: void servePackages(List<Map> pubspecs, {bool overwrite: false}) { On 2014/06/17 ...

6 years, 6 months ago (2014-06-17 21:12:45 UTC) #3

nweiz

6 years, 6 months ago (2014-06-17 21:13:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37424 (presubmit successful).

Expand Messages | Collapse Messages

Issue 334363004: Gracefully handle a missing locked version in pub get. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages