Issue 334293003: barback/test/package_graph/repetition_test times out in debug mode. Mark it as such.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334293003: barback/test/package_graph/repetition_test times out in debug mode. Mark it as such. (Closed)

Created:
6 years, 6 months ago by srdjan

Modified:
6 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

barback/test/package_graph/repetition_test times out in debug mode. Mark it as such. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=37372

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM But tests marked as timing out still slow down the development cycle and should ...

6 years, 6 months ago (2014-06-16 18:46:23 UTC) #2

srdjan

Committed patchset #1 manually as r37372 (presubmit successful).

6 years, 6 months ago (2014-06-16 19:44:29 UTC) #3

srdjan

6 years, 6 months ago (2014-06-16 19:46:08 UTC) #4

Message was sent while issue was closed.

On 2014/06/16 18:46:23, regis wrote:
> LGTM
> 
> But tests marked as timing out still slow down the development cycle and
should
> be fixed. I prefer to skip them and let the author speed them up.

You are right, but there are so many tests marked as such; will change all of
them to be skipped in debug mode (next CL).

Expand Messages | Collapse Messages