Issue 333963002: Retry renames on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333963002: Retry renames on Windows. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom

Modified:
6 years, 6 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Retry renames on Windows. BUG=https://code.google.com/p/dart/issues/detail?id=11887 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37427

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -38 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/io.dart	View		2 chunks	+48 lines, -38 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

This is a shot in the dark as far as whether or not it will ...

6 years, 6 months ago (2014-06-13 23:50:33 UTC) #1

nweiz

lgtm https://codereview.chromium.org/333963002/diff/1/sdk/lib/_internal/pub/lib/src/io.dart File sdk/lib/_internal/pub/lib/src/io.dart (right): https://codereview.chromium.org/333963002/diff/1/sdk/lib/_internal/pub/lib/src/io.dart#newcode306 sdk/lib/_internal/pub/lib/src/io.dart:306: operation(); It might be nice to catch the ...

6 years, 6 months ago (2014-06-16 20:02:14 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r37427 (presubmit successful).

6 years, 6 months ago (2014-06-17 21:23:28 UTC) #3

Bob Nystrom

6 years, 6 months ago (2014-06-17 21:30:29 UTC) #4

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/333963002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/333963002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/io.dart:306: operation();
On 2014/06/16 20:02:14, nweiz wrote:
> It might be nice to catch the error here as well and print a more detailed
error
> message explaining that a virus scanner may be causing pub to fail.

Done.

Expand Messages | Collapse Messages