Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 33383002: Correct rule for unqualified function invocations. (Closed)

Created:
7 years, 2 months ago by gbracha
Modified:
7 years, 2 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correct rule for unqualified function invocations. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=28954

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M docs/language/dartLangSpec.tex View 2 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
gbracha
7 years, 2 months ago (2013-10-21 18:38:10 UTC) #1
hausner
LGTM with comment. https://codereview.chromium.org/33383002/diff/1/docs/language/dartLangSpec.tex File docs/language/dartLangSpec.tex (right): https://codereview.chromium.org/33383002/diff/1/docs/language/dartLangSpec.tex#newcode3527 docs/language/dartLangSpec.tex:3527: %Otherwise, if there is an accessible ...
7 years, 2 months ago (2013-10-21 20:02:50 UTC) #2
gbracha
Committed patchset #1 manually as r28954 (presubmit successful).
7 years, 2 months ago (2013-10-21 21:29:36 UTC) #3
gbracha
7 years, 2 months ago (2013-10-21 21:29:51 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/33383002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/33383002/diff/1/docs/language/dartLangSpec.te...
docs/language/dartLangSpec.tex:3527: %Otherwise, if there is an accessible
(\ref{privacy}) static method named $id$ declared in a superclass $S$ of the
immediately enclosing class $C$ then i is equivalent to the static method
invocation $S.id(a_1, \ldots, a_n, x_{n+1}: a_{n+1}, \ldots, x_{n+k}: a_{n+k})$.
On 2013/10/21 20:02:50, hausner wrote:
> The above paragraph and the rationale is not present in the Docs version of
the
> spec.


It's commented out - in latex, the % sign begins a comment.

Powered by Google App Engine
This is Rietveld 408576698