Add support for ! and != to the new IR builder

Add support for ! and != to the new IR builder

R=asgerf@google.com, kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37582

[asgerf, 2014-06-18 12:41:45]

LGTM

[Kevin Millikin (Google), 2014-06-20 09:18:15]

LGTM with a naming suggestion.

https://codereview.chromium.org/333823005/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/333823005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:953: ir.Primitive
translateNot(ir.Primitive condition) {
Maybe "translate" is the wrong name, it's not translating anything and the
subexpression is already translated.

How about "buildNegation"?  (The spec calls ! negationOperator.)

[sigurdm, 2014-06-23 08:08:57]

https://codereview.chromium.org/333823005/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right):

https://codereview.chromium.org/333823005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:953: ir.Primitive
translateNot(ir.Primitive condition) {
On 2014/06/20 09:18:14, kmillikin wrote:
> Maybe "translate" is the wrong name, it's not translating anything and the
> subexpression is already translated.
> 
> How about "buildNegation"?  (The spec calls ! negationOperator.)

Much better name, thanks

[sigurdm, 2014-06-23 08:14:00]

Committed patchset #2 manually as r37582 (presubmit successful).