Add range analysis for left-shift smi operations.

Add range analysis for left-shift smi operations.

I factored some operations out into the Range and RangeBoundary class,
so that they can be used from unit tests and added cc tests.

R=johnmccutchan@google.com, vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37303

[Vyacheslav Egorov (Google), 2014-06-12 14:59:01]

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.cc:3251: intptr_t right_max =
Range::ConstantMax(right).value() > 0
Can be written as Max(Range::ConstantMax(right).value(), 0)

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.cc:3253: intptr_t right_min =
Range::ConstantMin(right).value() > 0
ditto

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2619: static RangeBoundary Shl(const
RangeBoundary& a,
operand a

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2620: intptr_t b,
more meaningful name: shift?

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2624: intptr_t limit = 63 - b;
I think this should be 64 (think b = 0).

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2629: int64_t result = a.value() << b;
this is intptr_t range shift

[Florian Schneider, 2014-06-12 15:12:43]

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.cc:3251: intptr_t right_max =
Range::ConstantMax(right).value() > 0
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> Can be written as Max(Range::ConstantMax(right).value(), 0)

Done.

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.cc:3253: intptr_t right_min =
Range::ConstantMin(right).value() > 0
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> ditto

Done.

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2619: static RangeBoundary Shl(const
RangeBoundary& a,
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> operand a

Done.

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2620: intptr_t b,
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> more meaningful name: shift?

Done.

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2624: intptr_t limit = 63 - b;
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> I think this should be 64 (think b = 0).

Done.

https://codereview.chromium.org/333643004/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language.h:2629: int64_t result = a.value() << b;
On 2014/06/12 14:59:00, Vyacheslav Egorov (Google) wrote:
> this is intptr_t range shift

Done.

[Vyacheslav Egorov (Google), 2014-06-12 15:46:17]

lgtm

https://codereview.chromium.org/333643004/diff/60001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_test.cc (right):

https://codereview.chromium.org/333643004/diff/60001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_test.cc:116: #undef TEST_RANGE_SHL
TEST_RANGE_OP

[Cutch, 2014-06-12 21:03:52]

lgtm

[Florian Schneider, 2014-06-13 07:12:21]

https://codereview.chromium.org/333643004/diff/60001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_test.cc (right):

https://codereview.chromium.org/333643004/diff/60001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_test.cc:116: #undef TEST_RANGE_SHL
On 2014/06/12 15:46:17, Vyacheslav Egorov (Google) wrote:
> TEST_RANGE_OP

Done.

[Florian Schneider, 2014-06-13 07:41:19]

Committed patchset #4 manually as r37303 (presubmit successful).