Issue 333583003: VM: Remove explicit field initialization with null from library classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333583003: VM: Remove explicit field initialization with null from library classes. (Closed)

Created:
6 years, 6 months ago by Florian Schneider

Modified:
6 years, 6 months ago

Reviewers:
Anders Johnsen, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Remove explicit field initialization with null from library classes. It is redundant since fields are implicitly null-initialized. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=37261

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	runtime/lib/collection_patch.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	runtime/lib/string_buffer_patch.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 manually as r37261 (presubmit successful).

6 years, 6 months ago (2014-06-12 10:59:25 UTC) #3

hausner

DBC: we would make the compiler drop these explicit initializations with null.

6 years, 6 months ago (2014-06-12 16:00:00 UTC) #4

Florian Schneider

6 years, 6 months ago (2014-06-13 07:34:20 UTC) #6

Message was sent while issue was closed.

On 2014/06/12 16:16:31, hausner wrote:
> s/would/could/

Yes, I agree. The allocation stub initializes all fields with null already, so
the explicit initializer is redundant.

Still, the library code should be as small as possible.

Expand Messages | Collapse Messages