Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 333453002: Reduce snapshot size by not writing null values for function code fields. (Closed)

Created:
6 years, 6 months ago by srdjan
Modified:
6 years, 6 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Reduce snapshot size by not writing null values for function code fields. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37243

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M runtime/vm/raw_object.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M tests/standalone/issue14236_test.dart View 1 Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
6 years, 6 months ago (2014-06-11 19:59:05 UTC) #1
Ivan Posva
LGTM -ip
6 years, 6 months ago (2014-06-11 20:00:52 UTC) #2
srdjan
6 years, 6 months ago (2014-06-11 20:11:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698