Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 333223011: fix chrome 35 polymer status (Closed)

Created:
6 years, 6 months ago by Jennifer Messerly
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix chrome 35 polymer status also mark one test passing on ie9 now One test is failing due to 35 having buggy custom elements, and I guess the newest polyfill removed the workaround(s) For now I marked status as failing, though bots will go red unfortunately when Chrome does update. I left the comment there to make it obvious to whoever sees that later. Committed: https://code.google.com/p/dart/source/detail?r=37635

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/pkg.status View 2 chunks +4 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
TBR
6 years, 6 months ago (2014-06-24 02:04:47 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r37635 (presubmit successful).
6 years, 6 months ago (2014-06-24 02:04:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/333223011/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/333223011/diff/1/pkg/pkg.status#newcode402 pkg/pkg.status:402: polymer/test/entered_view_test: Fail # Chrome 35 add also entered_left_view_test ...
6 years, 6 months ago (2014-06-24 02:06:27 UTC) #3
Jennifer Messerly
6 years, 6 months ago (2014-06-24 02:10:09 UTC) #4
Message was sent while issue was closed.
On 2014/06/24 02:06:27, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
> https://codereview.chromium.org/333223011/diff/1/pkg/pkg.status
> File pkg/pkg.status (right):
> 
> https://codereview.chromium.org/333223011/diff/1/pkg/pkg.status#newcode402
> pkg/pkg.status:402: polymer/test/entered_view_test: Fail # Chrome 35
> add also entered_left_view_test ?

Hmmm. I wasn't seeing that one fail when I ran locally.

Powered by Google App Engine
This is Rietveld 408576698