Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 33313003: Report use of malbounded interface in type test. (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Report use of malbounded interface in type test. Fix language tests related to malbounded types (issues 14123, 14131, 14132). R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -90 lines) Patch
M runtime/lib/errors_patch.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M runtime/lib/object.cc View 5 chunks +28 lines, -14 lines 0 comments Download
M runtime/vm/code_generator.cc View 11 chunks +41 lines, -40 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/malbounded_instantiation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/malbounded_type_cast_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/malbounded_type_test_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 2 months ago (2013-10-21 18:44:34 UTC) #1
rmacnak
LGTM
7 years, 2 months ago (2013-10-21 19:45:16 UTC) #2
regis
7 years, 2 months ago (2013-10-21 19:49:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698