Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 333073002: Support upgrading existing elements already on the page. (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support upgrading existing elements already on the page. R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=37338

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -21 lines) Patch
M pkg/web_components/lib/dart_support.js View 4 chunks +34 lines, -3 lines 0 comments Download
M pkg/web_components/lib/interop.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/web_components/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/web_components/test/interop_test.dart View 6 chunks +56 lines, -16 lines 0 comments Download
M pkg/web_components/test/interop_test.html View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-13 23:53:59 UTC) #1
justinfagnani
lgtm
6 years, 6 months ago (2014-06-14 00:25:42 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r37338 (presubmit successful).
6 years, 6 months ago (2014-06-14 00:27:23 UTC) #3
Jennifer Messerly
6 years, 6 months ago (2014-06-14 01:06:39 UTC) #4
Message was sent while issue was closed.
lgtm too

Powered by Google App Engine
This is Rietveld 408576698