Issue 332713002: dart2dart: Update status file for failing test case 05_Strings_A20_t01.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332713002: dart2dart: Update status file for failing test case 05_Strings_A20_t01. (Closed)

Created:
6 years, 6 months ago by asgerf

Modified:
6 years, 6 months ago

Reviewers:
karlklose, Kevin Millikin (Google), sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart: Update status file for failing test case 05_Strings_A20_t01. The test also fails in dart2js for the same reason. The DartString processor does not properly handle leading whitespace in a multiline string literal. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37265

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added reference to issue number. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/co19/co19-dart2js.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

asgerf

This should hopefully get the FYI builder green again. The problem is not specific to ...

6 years, 6 months ago (2014-06-12 10:40:27 UTC) #1

asgerf

This should hopefully get the FYI builder green again. The problem is not specific to ...

6 years, 6 months ago (2014-06-12 10:40:27 UTC) #2

karlklose

https://codereview.chromium.org/332713002/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/332713002/diff/1/tests/co19/co19-dart2dart.status#newcode86 tests/co19/co19-dart2dart.status:86: Language/12_Expressions/05_Strings_A20_t01: fail # co19-roll r546: Please triage this failure ...

6 years, 6 months ago (2014-06-12 11:35:32 UTC) #4

asgerf

6 years, 6 months ago (2014-06-12 12:07:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37265 (presubmit successful).

Expand Messages | Collapse Messages