pkg/matcher: add isNaN and isNotNaN matchers

add isNaN and isNotNaN to matchers

BUG= https://code.google.com/p/dart/issues/detail?id=19302
R=kevmoo@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38745

[kevmoo, 2014-07-22 20:44:37]

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
File pkg/matcher/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map matchState) =>
item == NaN;
Where is NaN coming from here? Do you mean double.NAN?

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map matchState) =>
item != NaN;
ditto

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/test/core_matche...
File pkg/matcher/test/core_matchers_test.dart (right):

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/test/core_matche...
pkg/matcher/test/core_matchers_test.dart:37: shouldPass(NaN, isNaN);
you need double.NAN here, right?

[srawlins, 2014-07-22 22:49:07]

Thanks Kevin; updated

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
File pkg/matcher/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map matchState) =>
item == NaN;
On 2014/07/22 20:44:37, kevmoo wrote:
> Where is NaN coming from here? Do you mean double.NAN?

Done.

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/lib/src/core_mat...
pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map matchState) =>
item != NaN;
On 2014/07/22 20:44:37, kevmoo wrote:
> ditto

Done.

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/test/core_matche...
File pkg/matcher/test/core_matchers_test.dart (right):

https://codereview.chromium.org/332663002/diff/1/pkg/matcher/test/core_matche...
pkg/matcher/test/core_matchers_test.dart:37: shouldPass(NaN, isNaN);
On 2014/07/22 20:44:37, kevmoo wrote:
> you need double.NAN here, right?

Done.

[kevmoo, 2014-07-25 18:21:09]

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
File pkg/matcher/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map matchState) =>
item == double.NaN;
double.NAN

Are you running tests locally before updating the CL?

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map matchState) =>
item != double.NaN;
ditto

[srawlins, 2014-07-30 17:08:04]

Sorry, I was _not_ running the correct set of tests; there was a flaw in this
implementation, and I've replaced my use of == with double.NAN.compareTo().
Thanks Kevin!!!

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
File pkg/matcher/lib/src/core_matchers.dart (right):

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map matchState) =>
item == double.NaN;
On 2014/07/25 18:21:08, kevmoo wrote:
> double.NAN
> 
> Are you running tests locally before updating the CL?

Sorry, I was _not_ running the correct set of tests; there was a flaw in this
implementation, and I've replaced my use of == with double.NAN.compareTo().
Thanks Kevin!!!

https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map matchState) =>
item != double.NaN;
On 2014/07/25 18:21:08, kevmoo wrote:
> ditto

Done.

[kevmoo, 2014-07-30 17:46:43]

On 2014/07/30 17:08:04, srawlins wrote:
> Sorry, I was _not_ running the correct set of tests; there was a flaw in this
> implementation, and I've replaced my use of == with double.NAN.compareTo().
> Thanks Kevin!!!
> 
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> File pkg/matcher/lib/src/core_matchers.dart (right):
> 
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map matchState)
=>
> item == double.NaN;
> On 2014/07/25 18:21:08, kevmoo wrote:
> > double.NAN
> > 
> > Are you running tests locally before updating the CL?
> 
> Sorry, I was _not_ running the correct set of tests; there was a flaw in this
> implementation, and I've replaced my use of == with double.NAN.compareTo().
> Thanks Kevin!!!
> 
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map matchState)
=>
> item != double.NaN;
> On 2014/07/25 18:21:08, kevmoo wrote:
> > ditto
> 
> Done.

Please update pubspec.yaml version to 0.11.1

Also update the changelog to reflect this addition.

Please remove the fix to the intl pkg. Send a separate CL for that update and CC
alanknight when this change has landed and deployed to pub.

Thanks!

[srawlins, 2014-07-30 18:40:03]

On 2014/07/30 17:46:43, kevmoo wrote:
> On 2014/07/30 17:08:04, srawlins wrote:
> > Sorry, I was _not_ running the correct set of tests; there was a flaw in
this
> > implementation, and I've replaced my use of == with double.NAN.compareTo().
> > Thanks Kevin!!!
> > 
> >
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> > File pkg/matcher/lib/src/core_matchers.dart (right):
> > 
> >
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> > pkg/matcher/lib/src/core_matchers.dart:75: bool matches(item, Map
matchState)
> =>
> > item == double.NaN;
> > On 2014/07/25 18:21:08, kevmoo wrote:
> > > double.NAN
> > > 
> > > Are you running tests locally before updating the CL?
> > 
> > Sorry, I was _not_ running the correct set of tests; there was a flaw in
this
> > implementation, and I've replaced my use of == with double.NAN.compareTo().
> > Thanks Kevin!!!
> > 
> >
>
https://codereview.chromium.org/332663002/diff/20001/pkg/matcher/lib/src/core...
> > pkg/matcher/lib/src/core_matchers.dart:81: bool matches(item, Map
matchState)
> =>
> > item != double.NaN;
> > On 2014/07/25 18:21:08, kevmoo wrote:
> > > ditto
> > 
> > Done.
> 
> Please update pubspec.yaml version to 0.11.1
> 
> Also update the changelog to reflect this addition.
> 
> Please remove the fix to the intl pkg. Send a separate CL for that update and
CC
> alanknight when this change has landed and deployed to pub.
> 
> Thanks!

Done, done, and done. Thanks Kevin.

[kevmoo, 2014-07-30 19:03:34]

LGTM w/ nits

Please update and I'll commit

https://codereview.chromium.org/332663002/diff/60001/pkg/matcher/CHANGELOG.md
File pkg/matcher/CHANGELOG.md (right):

https://codereview.chromium.org/332663002/diff/60001/pkg/matcher/CHANGELOG.md...
pkg/matcher/CHANGELOG.md:3: * Added `isNaN()` and `isNotNaN()` matchers.
remove parens

[srawlins, 2014-07-30 19:05:47]

https://codereview.chromium.org/332663002/diff/60001/pkg/matcher/CHANGELOG.md
File pkg/matcher/CHANGELOG.md (right):

https://codereview.chromium.org/332663002/diff/60001/pkg/matcher/CHANGELOG.md...
pkg/matcher/CHANGELOG.md:3: * Added `isNaN()` and `isNotNaN()` matchers.
On 2014/07/30 19:03:34, kevmoo wrote:
> remove parens

Done.

[kevmoo, 2014-07-30 19:12:21]

Committed patchset #5 manually as r38745 (presubmit successful).