Issue 332383006: Trigger re-analysis when a file changes on disk.

Issue 332383006: Trigger re-analysis when a file changes on disk. (Closed)

Created:
6 years, 6 months ago by Paul Berry

Modified:
6 years, 6 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Trigger re-analysis when a file changes on disk. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=37408

Patch Set 2 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -13 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/context_directory_manager.dart	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/context_directory_manager_test.dart	View		5 chunks	+36 lines, -10 lines	2 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	1	1 chunk	+18 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/test_all.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/332383006/diff/20001/pkg/analysis_server/test/context_directory_manager_test.dart File pkg/analysis_server/test/context_directory_manager_test.dart (right): https://codereview.chromium.org/332383006/diff/20001/pkg/analysis_server/test/context_directory_manager_test.dart#newcode19 pkg/analysis_server/test/context_directory_manager_test.dart:19: * Source of timestamps stored in [currentContextFilePaths] Missing ...

6 years, 6 months ago (2014-06-17 17:55:03 UTC) #2

Paul Berry

https://codereview.chromium.org/332383006/diff/20001/pkg/analysis_server/test/context_directory_manager_test.dart File pkg/analysis_server/test/context_directory_manager_test.dart (right): https://codereview.chromium.org/332383006/diff/20001/pkg/analysis_server/test/context_directory_manager_test.dart#newcode19 pkg/analysis_server/test/context_directory_manager_test.dart:19: * Source of timestamps stored in [currentContextFilePaths] On 2014/06/17 ...

6 years, 6 months ago (2014-06-17 18:07:50 UTC) #3

Paul Berry

6 years, 6 months ago (2014-06-17 18:08:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37408 (presubmit successful).

Expand Messages | Collapse Messages