Issue 332153004: Improve test_runner_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332153004: Improve test_runner_test. (Closed)

Created:
6 years, 6 months ago by Bill Hesse

Modified:
6 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve test_runner_test. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=37350

Patch Set 2 : Indentation #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tests/standalone/io/test_runner_test.dart	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm Though this CL doesn't add that much information. https://codereview.chromium.org/332153004/diff/1/tests/standalone/io/test_runner_test.dart File tests/standalone/io/test_runner_test.dart (right): https://codereview.chromium.org/332153004/diff/1/tests/standalone/io/test_runner_test.dart#newcode34 tests/standalone/io/test_runner_test.dart:34: ...

6 years, 6 months ago (2014-06-16 08:26:29 UTC) #2

Bill Hesse

6 years, 6 months ago (2014-06-16 09:19:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r37350 (presubmit successful).

Expand Messages | Collapse Messages

Issue 332153004: Improve test_runner_test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Indentation #

Messages