Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 331673003: Resolve symlinks before determining relative path. (Closed)

Created:
6 years, 6 months ago by Bob Nystrom
Modified:
6 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Resolve symlinks before determining relative path. BUG=https://code.google.com/p/dart/issues/detail?id=9418 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=37283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Here's a less intrusive fix for that bug. I didn't bother writing a test since ...
6 years, 6 months ago (2014-06-12 17:53:30 UTC) #1
nweiz
lgtm
6 years, 6 months ago (2014-06-12 18:01:33 UTC) #2
Bob Nystrom
6 years, 6 months ago (2014-06-12 18:40:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698