Issue 331603002: Fix caching paging during read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331603002: Fix caching paging during read. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix caching paging during read. Preliminary performance numbers: about 2000 ms to insert 1 million key/value pairs. Page size is 8K, cache is 16 index nodes and 128 leaf nodes. Key is Uint32List(7) = 28 bytes and value is Uint32. I.e. it is basically ElementId to an artificial incremental id. Keys are sequencial, with randomization every 100 keys - add a random number from the range [-5000, 5000). I hope that it is a good simulation for our Element keys - they tend to group by libraries and parts. So, our cache should be able to keep corresponding index/leaf nodes in memory. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37274

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -29 lines)			Patch
M	pkg/analysis_server/lib/src/index/b_plus_tree.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/index/page_node_manager.dart	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/test/index/page_node_manager_test.dart	View	5 chunks	+44 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 6 months ago (2014-06-12 14:25:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r37274 (presubmit successful).

Expand Messages | Collapse Messages