Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 331353005: Deal with ImputEvent in Firefox. (Closed)

Created:
6 years, 5 months ago by Emily Fortuna
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Emily Fortuna
6 years, 5 months ago (2014-06-30 16:10:38 UTC) #1
Emily Fortuna
This is a fix for https://code.google.com/p/dart/issues/detail?id=19489
6 years, 5 months ago (2014-06-30 16:10:56 UTC) #2
blois
https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart File sdk/lib/_internal/lib/native_helper.dart (right): https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart#newcode625 sdk/lib/_internal/lib/native_helper.dart:625: "InputEvent": "Event", When do we use this map vs ...
6 years, 5 months ago (2014-06-30 16:16:25 UTC) #3
blois
+sra
6 years, 5 months ago (2014-06-30 16:16:39 UTC) #4
Emily Fortuna
On 2014/06/30 16:16:25, blois wrote: > https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart > File sdk/lib/_internal/lib/native_helper.dart (right): > > https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart#newcode625 > ...
6 years, 5 months ago (2014-06-30 16:18:57 UTC) #5
Emily Fortuna
https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart File sdk/lib/_internal/lib/native_helper.dart (right): https://codereview.chromium.org/331353005/diff/1/sdk/lib/_internal/lib/native_helper.dart#newcode625 sdk/lib/_internal/lib/native_helper.dart:625: "InputEvent": "Event", On 2014/06/30 16:16:25, blois wrote: > When ...
6 years, 5 months ago (2014-06-30 16:19:36 UTC) #6
Jennifer Messerly
lgtm! thank you!
6 years, 5 months ago (2014-06-30 20:23:36 UTC) #7
blois
lgtm
6 years, 5 months ago (2014-06-30 21:10:47 UTC) #8
Emily Fortuna
Committed patchset #2 manually as r37838 (presubmit successful).
6 years, 5 months ago (2014-06-30 22:07:13 UTC) #9
kasperl
6 years, 5 months ago (2014-07-01 07:09:02 UTC) #10
Message was sent while issue was closed.
Is this something we should be merging to branches/1.5?

Powered by Google App Engine
This is Rietveld 408576698