Issue 330863002: More fixes to test expectations on dart2js-chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330863002: More fixes to test expectations on dart2js-chrome. (Closed)

Created:
6 years, 6 months ago by karlklose

Modified:
6 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

More fixes to test expectations on dart2js-chrome. TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=37318

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -4 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+1 line, -0 lines	2 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

Committed patchset #1 manually as r37318 (presubmit successful).

6 years, 6 months ago (2014-06-13 16:54:14 UTC) #2

ricow1

lgtm with comment https://codereview.chromium.org/330863002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/330863002/diff/1/pkg/pkg.status#newcode91 pkg/pkg.status:91: pkg/web_components/test/interop_test: Fail # Issue 19329 remove ...

6 years, 6 months ago (2014-06-13 17:13:03 UTC) #3

karlklose

6 years, 6 months ago (2014-06-13 17:49:48 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/330863002/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/330863002/diff/1/pkg/pkg.status#newcode91
pkg/pkg.status:91: pkg/web_components/test/interop_test: Fail # Issue 19329
On 2014/06/13 17:13:03, ricow1 wrote:
> remove pkg/

Oops! Thanks for catching it. However, it seems that the test actually passes
now. I'll send a CL to remove the line.

Expand Messages | Collapse Messages