Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 330683003: Use dart.js in release mode to workaround dartbug.com/19653 (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use dart.js in release mode to workaround dartbug.com/19653 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37753

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/polymer/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/all_phases_test.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/polymer/test/build/polyfill_injector_test.dart View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-26 01:54:45 UTC) #1
Siggi Cherem (dart-lang)
actually - I uploaded a new patch switching the implementation entirely. There was 1 test ...
6 years, 6 months ago (2014-06-26 17:59:56 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/330683003/diff/20001/pkg/polymer/lib/src/build/polyfill_injector.dart File pkg/polymer/lib/src/build/polyfill_injector.dart (right): https://codereview.chromium.org/330683003/diff/20001/pkg/polymer/lib/src/build/polyfill_injector.dart#newcode81 pkg/polymer/lib/src/build/polyfill_injector.dart:81: // TODO(sigmund): remove async (workaround for dartbug.com/19653). at ...
6 years, 6 months ago (2014-06-26 19:17:54 UTC) #3
Siggi Cherem (dart-lang)
thanks! https://codereview.chromium.org/330683003/diff/20001/pkg/polymer/lib/src/build/polyfill_injector.dart File pkg/polymer/lib/src/build/polyfill_injector.dart (right): https://codereview.chromium.org/330683003/diff/20001/pkg/polymer/lib/src/build/polyfill_injector.dart#newcode81 pkg/polymer/lib/src/build/polyfill_injector.dart:81: // TODO(sigmund): remove async (workaround for dartbug.com/19653). On ...
6 years, 6 months ago (2014-06-26 20:00:52 UTC) #4
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-26 20:06:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r37753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698