Issue 330333004: Limit canvas height in heap map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330333004: Limit canvas height in heap map. (Closed)

Created:
6 years, 6 months ago by koda

Modified:
6 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Limit canvas height in heap map. Apparently many broswers fail to display a canvas taller than 6K-8K pixels. This is a stop-gap solution that stops loading pages when max height has been reached, and displays the correct total count for the user. Longer-term, we should provide a less detailed, high-level view for huge heaps. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=37366

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	runtime/bin/vmservice/client/lib/src/elements/heap_map.dart	View	1 2 3	4 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 6 months ago (2014-06-16 17:09:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r37366 (presubmit successful).

Expand Messages | Collapse Messages